linux-kernel - Re: [PATCH] fence: add missing descriptions for fence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABxcv==y2D=B7Rf-8PsMzHfeqaoetV5xJXNQt0ZSn7-WK0ZuLw@mail.gmail.com>
Date:	Sat, 19 Mar 2016 20:55:15 -0300
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	Luis de Bethencourt <luisbg@....samsung.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	sumit.semwal@...aro.org,
	Linux Media Mailing List <linux-media@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	linaro-mm-sig@...ts.linaro.org
Subject: Re: [PATCH] fence: add missing descriptions for fence

Hello Luis,

On Sat, Mar 19, 2016 at 4:50 PM, Luis de Bethencourt
<luisbg@....samsung.com> wrote:
> Commit b55b54b5db33 ("staging/android: remove struct sync_pt")
> added the members child_list and active_list to the fence struct, but
> didn't add descriptions for these. Adding the descriptions.
>

Patches whose commit message mentions a specific commit that
introduced and issue, usually also have a "Fixes:" tag before the
S-o-B. For example this patch should have:

Fixes: b55b54b5db33 ("staging/android: remove struct sync_pt")
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> ---
> Hi,
>
> Noticed this missing descriptions when running make htmldocs.
>
> Got the following warnings:
> .//include/linux/fence.h:84: warning: No description found for parameter 'child_list'
> .//include/linux/fence.h:84: warning: No description found for parameter 'active_list'
>
> Thanks :)
> Luis
>

Patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>

Best regards,
Javier