linux-kernel - Re: [GIT PULL] Block driver changes for 4.6-rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyq6pWh9jFuAk3qSes21-Q_meHhhkQ90tbZcT+S0XcBqQ@mail.gmail.com>
Date:	Fri, 18 Mar 2016 17:32:29 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jens Axboe <axboe@...com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-block@...r.kernel.org
Subject: Re: [GIT PULL] Block driver changes for 4.6-rc

On Fri, Mar 18, 2016 at 10:33 AM, Jens Axboe <axboe@...com> wrote:
>
> 1) Pull for-4.6/drivers and do the merges yourself. This is the original
>    branch.
>
> 2) Pull for-4.6/drivers-merged, which is the above branch, but with v4.5
>    merged into it and the merges resolved cleanly.

I don't think your merge is correct.

I pushed out mine.

So the differences are (apart from purely newline changes):

 - you kept the early "flush_work(&dev->reset_work)", so your merge
didn't take the changes from commit
ff23a2a15a2117245b4599c1352343c8b8fb4c43 properly, and you flush the
work twice.

   I don't know that it matters, but it looks odd.

 - Your merge dropped the nvme_dev_disable() from
nvme_remove_dead_ctrl(), added by commit
69d9a99c258eb1d6478fd9608a2070890797eed7

 - Your merge kept the redundant dev_set_drvdata() in
nvme_init_ctrl(), removed by commit
f4f0f63e6f01055dfbdb7bc5e83935e1bdfa1980.

Anyway, since I got a different merge result than you did, you should
double-check, but I think I did the merge correctly.

But I don't know the code nor the hardware, so I'm just going by
reading the commits.

I also do have to ask: why the hell is nvme development done in that
insane way? Why the f*ck can people not work together? Why are these
two different groups messing with each others code?

Tell them to stop.

I'm not happy with how messy these block layer pulls are.

                Linus

               Linus