linux-kernel - Re: [PATCH] Coccinelle: setup_timer: Add space in front of parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1603201325011.2597@hadrien>
Date:	Sun, 20 Mar 2016 13:25:28 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Vaishali Thakkar <vaishali.thakkar@...cle.com>
cc:	mmarek@...e.com, Gilles.Muller@...6.fr, nicolas.palix@...g.fr,
	linux-kernel@...r.kernel.org, cocci@...teme.lip6.fr, nm@...com,
	julia.lawall@...6.fr
Subject: Re: [PATCH] Coccinelle: setup_timer: Add space in front of
 parentheses



On Sun, 20 Mar 2016, Vaishali Thakkar wrote:

> Add space in front of the offending parentheses to silent the
> parse error for older Coccinelle versions. This makes the rule
> usable with all Coccinelle versions.
>
> Reported-by: Nishanth Menon <nm@...com>
> Signed-off-by: Vaishali Thakkar <vaishali.thakkar@...cle.com>

Acked-by: Julia Lawall <julia.lawall@...6.fr>

> ---
>  scripts/coccinelle/api/setup_timer.cocci | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/coccinelle/api/setup_timer.cocci b/scripts/coccinelle/api/setup_timer.cocci
> index 8ee0ac3..eb6bd9e 100644
> --- a/scripts/coccinelle/api/setup_timer.cocci
> +++ b/scripts/coccinelle/api/setup_timer.cocci
> @@ -106,7 +106,7 @@ position j0, j1, j2;
>  @match_function_and_data_after_init_timer_context
>  depends on !patch &&
>  !match_immediate_function_data_after_init_timer_context &&
> -(context || org || report)@
> + (context || org || report)@
>  expression a, b, e1, e2, e3, e4, e5;
>  position j0, j1, j2;
>  @@
> @@ -127,7 +127,7 @@ position j0, j1, j2;
>  @r3_context depends on !patch &&
>  !match_immediate_function_data_after_init_timer_context &&
>  !match_function_and_data_after_init_timer_context &&
> -(context || org || report)@
> + (context || org || report)@
>  expression c, e6, e7;
>  position r1.p;
>  position j0, j1;
> --
> 2.1.4
>
>