linux-kernel - Re: [PATCH 3/3] mm: drop PAGE_CACHE_* and page_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160321125335.GE23066@dhcp22.suse.cz>
Date:	Mon, 21 Mar 2016 13:53:35 +0100
From:	Michal Hocko <mhocko@...nel.org>
To:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Christoph Lameter <cl@...ux.com>,
	Matthew Wilcox <willy@...ux.intel.com>,
	Hugh Dickins <hughd@...gle.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 3/3] mm: drop PAGE_CACHE_* and page_cache_{get,release}
 definition

On Mon 21-03-16 15:06:38, Kirill A. Shutemov wrote:
> All users gone. We can remove these macros.
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

\o/

Acked-by: Michal Hocko <mhocko@...e.com>

Thanks!

> ---
>  include/linux/pagemap.h | 15 ---------------
>  1 file changed, 15 deletions(-)
> 
> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
> index b3fc0370c14f..7e1ab155c67c 100644
> --- a/include/linux/pagemap.h
> +++ b/include/linux/pagemap.h
> @@ -86,21 +86,6 @@ static inline void mapping_set_gfp_mask(struct address_space *m, gfp_t mask)
>  				(__force unsigned long)mask;
>  }
>  
> -/*
> - * The page cache can be done in larger chunks than
> - * one page, because it allows for more efficient
> - * throughput (it can then be mapped into user
> - * space in smaller chunks for same flexibility).
> - *
> - * Or rather, it _will_ be done in larger chunks.
> - */
> -#define PAGE_CACHE_SHIFT	PAGE_SHIFT
> -#define PAGE_CACHE_SIZE		PAGE_SIZE
> -#define PAGE_CACHE_MASK		PAGE_MASK
> -#define PAGE_CACHE_ALIGN(addr)	(((addr)+PAGE_CACHE_SIZE-1)&PAGE_CACHE_MASK)
> -
> -#define page_cache_get(page)		get_page(page)
> -#define page_cache_release(page)	put_page(page)
>  void release_pages(struct page **pages, int nr, bool cold);
>  
>  /*
> -- 
> 2.7.0

-- 
Michal Hocko
SUSE Labs