linux-kernel - Re: [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 21 Mar 2016 09:06:03 -0500
From:	Andreas Dannenberg <dannenberg@...com>
To:	Rob Herring <robh@...nel.org>
CC:	<alsa-devel@...a-project.org>, <devicetree@...r.kernel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT
 bindings

On Mon, Mar 21, 2016 at 07:45:55AM -0500, Rob Herring wrote:
> > +Optional properties:
> > +
> > +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry
> > +- pvdd-supply : phandle to a supply used for the Class-D amp and the analog
> > +- interrupts-extended : reference to a GPIO pin connected to the TAS5720
> > +                        FAULTZ pin for error reporting purposes
> 
> There's no point in having interrupts-extended here with a single 
> interrupt. It is fine to use, but really that's outside the scope of 
> this binding. So I'd just document "interrupts" here as that is what 
> most docs do, and that implies interrupts-extended could be used.

Hi Rob,
Good point. Will remove it for v2.

Regards,

--
Andreas Dannenberg
Texas Instruments Inc