linux-kernel - Re: [PATCH net 03/10] net: hns: add uc match for debug ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160321.114055.845640249977716034.davem@davemloft.net>
Date:	Mon, 21 Mar 2016 11:40:55 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Yisen.Zhuang@...wei.com
Cc:	yankejian@...wei.com, huangdaode@...ilicon.com,
	salil.mehta@...wei.com, lisheng011@...wei.com,
	lipeng321@...wei.com, liguozhu@...wei.com, arnd@...db.de,
	xieqianqian@...wei.com, andrew@...n.ch, ivecera@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linuxarm@...wei.com
Subject: Re: [PATCH net 03/10] net: hns: add uc match for debug ports

From: Yisen Zhuang <Yisen.Zhuang@...wei.com>
Date: Mon, 21 Mar 2016 19:06:34 +0800

> +	(void)hns_mac_set_promisc(mac_cb, (u8)!!en);

This cast to void is unnecssary.

> +static void hns_gmac_set_uc_match(void *mac_drv, u16 en)
> +{
> +	struct mac_driver *drv = (struct mac_driver *)mac_drv;

Casts from void pointers are unnecessary.

> +{
> +	struct mac_driver *drv = (struct mac_driver *)mac_drv;

Likewise.