linux-kernel - Re: [PATCH v5 1/3] gpio: designware: convert device node to fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYb8HYXta3yHB4-n-KtSAhyrREUGJJMOUbt3ZXvSUbn6Q@mail.gmail.com>
Date:	Tue, 22 Mar 2016 11:38:26 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	qiujiang <qiujiang@...wei.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Lee Jones <lee.jones@...aro.org>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Linuxarm <linuxarm@...wei.com>, haifeng.wei@...wei.com,
	charles.chenxin@...wei.com
Subject: Re: [PATCH v5 1/3] gpio: designware: convert device node to fwnode

On Fri, Mar 4, 2016 at 8:44 AM, qiujiang <qiujiang@...wei.com> wrote:

> This patch converts device node to fwnode in
> dwapb_port_property for designware gpio driver,
> so as to provide a unified data structure for DT
> and ACPI bindings.
>
> Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Signed-off-by: qiujiang <qiujiang@...wei.com>

I need Mika's and maybe also Rafael's ACKs on this before
I merge any of the series.

> --- a/drivers/mfd/intel_quark_i2c_gpio.c
> +++ b/drivers/mfd/intel_quark_i2c_gpio.c
> @@ -227,7 +227,7 @@ static int intel_quark_gpio_setup(struct pci_dev *pdev, struct mfd_cell *cell)
>                 return -ENOMEM;
>
>         /* Set the properties for portA */
> -       pdata->properties->node         = NULL;
> +       pdata->properties->fwnode       = NULL;

And apparently also the MFD maintainer needs to be involved to ACK this,
so add Lee Jones on subsequent postings.

Yours,
Linus Walleij