linux-kernel - Re: [PATCH 0/3] fs, mm: get rid of PAGE_CACHE_* and page_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160322104113.GA143214@black.fi.intel.com>
Date:	Tue, 22 Mar 2016 13:41:13 +0300
From:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
To:	Christoph Lameter <cl@...ux.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Matthew Wilcox <willy@...ux.intel.com>,
	Hugh Dickins <hughd@...gle.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 0/3] fs, mm: get rid of PAGE_CACHE_* and
 page_cache_{get,release} macros

On Mon, Mar 21, 2016 at 12:29:34PM -0500, Christoph Lameter wrote:
> On Mon, 21 Mar 2016, Kirill A. Shutemov wrote:
> 
> > We do have two page sizes in the page cache. It's the only option to get
> > transparent huge pages transparent.
> 
> Should then not PAGE_CACHE_SIZE take a page parameter and return the
> correct page size?

Why? What would you achieve by this?

We already have a way to find out size of page: compoun_order() or
hpage_nr_pages().

And not in every place where PAGE_CACHE_SIZE is used we have corresponding
struct page.

-- 
 Kirill A. Shutemov