linux-kernel - Re: [PATCH v11] cpufreq: powernv: Add sysfs attributes to show throttle stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160322024627.GP27778@vireshk-i7>
Date:	Tue, 22 Mar 2016 08:16:27 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>
Cc:	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org,
	ego@...ux.vnet.ibm.com, linux-pm@...r.kernel.org,
	rjw@...ysocki.net, shreyas@...ux.vnet.ibm.com,
	linux-api@...r.kernel.org
Subject: Re: [PATCH v11] cpufreq: powernv: Add sysfs attributes to show
 throttle stats

On 21-03-16, 22:29, Shilpasri G Bhat wrote:
> +	create_throttle_sysfs = kcalloc(cpu_nr_cores(), sizeof(bool),
> +					GFP_KERNEL);
> +	if (!create_throttle_sysfs) {
> +		kfree(chips);
> +		return -ENOMEM;
> +	}
> +
>  	for (i = 0; i < nr_chips; i++) {
>  		chips[i].id = chip[i];
>  		cpumask_copy(&chips[i].mask, cpumask_of_node(chip[i]));
> @@ -582,6 +655,7 @@ static int init_chip_info(void)
>  
>  static inline void clean_chip_info(void)
>  {
> +	kfree(create_throttle_sysfs);
>  	kfree(chips);
>  }

Why do you need this at all?. You can use policy->driver data, isn't
it ?

-- 
viresh