linux-kernel - Re: [PATCH] regmap: mmio: Fix value endianness selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2609570.vvhKhym0nL@ws-stein>
Date:	Wed, 23 Mar 2016 15:20:46 +0100
From:	Alexander Stein <alexander.stein@...tec-electronic.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: mmio: Fix value endianness selection

On Wednesday 23 March 2016 13:17:59, Mark Brown wrote:
> Currently when selecting value endianness we check the register
> endiannes, not the value endianness.
> 
> Reported-by: Alexander Stein <alexander.stein@...tec-electronic.com>
> Signed-off-by: Mark Brown <broonie@...nel.org>

Mh, while this _does_ fix the problem regarding accessing SCFG peripheral 
using syscon, it _does not_ fix the access for spi-fsl-dspi, this is still 
using little-endian.
The difference in those drivers is that syscon manually sets 
config.val_format_endian before calling regmap_init_mmio.
spi-fsl-dspi does not. I guess this driver relies on this configuration being 
done in regmap_get_val_endian. But this is never reached because after setting 
map->reg_read this code is skipped due to "goto skip_format_initialization;"
IMHO a call to regmap_get_val_endian should be added to 
regmap_mmio_gen_context.

Best regards,
Alexander