linux-kernel - Re: [PATCH] regmap: mmio: Fix value endianness selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160325112459.GD2566@sirena.org.uk>
Date:	Fri, 25 Mar 2016 11:24:59 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Alexander Stein <alexander.stein@...tec-electronic.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: mmio: Fix value endianness selection

On Wed, Mar 23, 2016 at 03:20:46PM +0100, Alexander Stein wrote:

> The difference in those drivers is that syscon manually sets 
> config.val_format_endian before calling regmap_init_mmio.
> spi-fsl-dspi does not. I guess this driver relies on this configuration being 
> done in regmap_get_val_endian. But this is never reached because after setting 
Does this IP exist in configurations where it is anything other than big
endian?  If not then this probably shouldn't be in DT.

> map->reg_read this code is skipped due to "goto skip_format_initialization;"
> IMHO a call to regmap_get_val_endian should be added to 
> regmap_mmio_gen_context.

That sounds reasonable.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)