linux-kernel - Re: [PATCH v6] acpi: Issue _OSC call for native thermal interrupt handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 24 Mar 2016 02:28:59 +0100
From:	"Rafael J. Wysocki" <rafael@...nel.org>
To:	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc:	Linda Knippers <linda.knippers@....com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Tony Luck <tony.luck@...el.com>,
	Borislav Petkov <bp@...en8.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, Len Brown <lenb@...nel.org>,
	"open list:EDAC-CORE" <linux-edac@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH v6] acpi: Issue _OSC call for native thermal interrupt handling

On Wed, Mar 23, 2016 at 9:22 PM, Srinivas Pandruvada
<srinivas.pandruvada@...ux.intel.com> wrote:
> On Wed, 2016-03-23 at 12:43 -0400, Linda Knippers wrote:
>> I raised a general concern on a previous patch so I found a 1P server
>> with Skylake and HWP to try.  This doesn't qualify as a tested-by
>> since all I did was apply the patch and boot the server but hey, it
>> booted.
> Thanks.
>
>>
>> I do have a question below...
>>
> [...]
>> +     if (ACPI_SUCCESS(acpi_run_osc(handle, &osc_context))) {
>> > +           acpi_hwp_native_thermal_lvt_set = true;
>> > +           kfree(osc_context.ret.pointer);
>>
>> There are other boot messages that indicate when something is
>> happening
>> with _OSC.  Should there be one for this?  Or is there some other
>> obvious
>> way one can know that this was set?
>>
> I am following model of acpi_bus_osc_support, which issues _OSC for
> global platform scope, where nothing is getting printed. If it is
> useful, I don't mind adding a print.
>
> Rafael,
>         What do you think?

Printing a message after acpi_run_osc() has been called successfully
shouldn't hurt.  Maybe using acpi_handle_info()?

Thanks,
Rafael