linux-kernel - Re: [PATCH v6] acpi: Issue _OSC call for native thermal interrupt handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1458764521.27934.168.camel@linux.intel.com>
Date:	Wed, 23 Mar 2016 13:22:01 -0700
From:	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:	Linda Knippers <linda.knippers@....com>, rjw@...ysocki.net
Cc:	tony.luck@...el.com, bp@...en8.de, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, lenb@...nel.org,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH v6] acpi: Issue _OSC call for native thermal interrupt
 handling

On Wed, 2016-03-23 at 12:43 -0400, Linda Knippers wrote:
> I raised a general concern on a previous patch so I found a 1P server
> with Skylake and HWP to try.  This doesn't qualify as a tested-by
> since all I did was apply the patch and boot the server but hey, it
> booted.
Thanks.

> 
> I do have a question below...
> 
[...]
> +	if (ACPI_SUCCESS(acpi_run_osc(handle, &osc_context))) {
> > +		acpi_hwp_native_thermal_lvt_set = true;
> > +		kfree(osc_context.ret.pointer);
> 
> There are other boot messages that indicate when something is
> happening
> with _OSC.  Should there be one for this?  Or is there some other
> obvious
> way one can know that this was set?
> 
I am following model of acpi_bus_osc_support, which issues _OSC for
global platform scope, where nothing is getting printed. If it is
useful, I don't mind adding a print.

Rafael,
	What do you think?

Thanks,
Srinivas