linux-kernel - Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160323202521.GA31744@roeck-us.net>
Date:	Wed, 23 Mar 2016 13:25:21 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Xuetao Guan <gxt@...c.pku.edu.cn>
Cc:	linux-kernel@...r.kernel.org,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] unicore32: mm: Add missing parameter to
 arch_vma_access_permitted

On Mon, Mar 21, 2016 at 07:47:29PM +0800, Xuetao Guan wrote:
> > unicore32 fails to compile with the following errors.
> >
> > mm/memory.c: In function 鈥榑_handle_mm_fault鈥&#65533;:
> > mm/memory.c:3381: error:
> > 	too many arguments to function 鈥榓rch_vma_access_permitted鈥&#65533;
> > mm/gup.c: In function 鈥榗heck_vma_flags鈥&#65533;:
> > mm/gup.c:456: error:
> > 	too many arguments to function 鈥榓rch_vma_access_permitted鈥&#65533;
> > mm/gup.c: In function 鈥榲ma_permits_fault鈥&#65533;:
> > mm/gup.c:640: error:
> > 	too many arguments to function 鈥榓rch_vma_access_permitted鈥&#65533;
> >
> > Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction
> > fetches")
> > Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Ingo Molnar <mingo@...nel.org>
> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> 
> Thanks.
> 
> Acked-by: Guan Xuetao <gxt@...c.pku.edu.cn>
> 
Who is going to send the patch upstream ?

Guenter

> > ---
> >  arch/unicore32/include/asm/mmu_context.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/unicore32/include/asm/mmu_context.h
> > b/arch/unicore32/include/asm/mmu_context.h
> > index e35632ef23c7..62dfc644c908 100644
> > --- a/arch/unicore32/include/asm/mmu_context.h
> > +++ b/arch/unicore32/include/asm/mmu_context.h
> > @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct
> > *mm,
> >  }
> >
> >  static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
> > -		bool write, bool foreign)
> > +		bool write, bool execute, bool foreign)
> >  {
> >  	/* by default, allow everything */
> >  	return true;
> > --
> > 2.5.0
> >
>