linux-kernel - Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62869.117.114.135.40.1458779934.squirrel@mprc.pku.edu.cn>
Date:	Thu, 24 Mar 2016 08:38:54 +0800 (CST)
From:	"Xuetao Guan" <gxt@...c.pku.edu.cn>
To:	"Guenter Roeck" <linux@...ck-us.net>
Cc:	"Xuetao Guan" <gxt@...c.pku.edu.cn>, linux-kernel@...r.kernel.org,
	"Dave Hansen" <dave.hansen@...ux.intel.com>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Ingo Molnar" <mingo@...nel.org>
Subject: Re: [PATCH] unicore32: mm: Add missing parameter to 
     arch_vma_access_permitted

> On Mon, Mar 21, 2016 at 07:47:29PM +0800, Xuetao Guan wrote:
>> > unicore32 fails to compile with the following errors.
>> >
>> > mm/memory.c: In function ��ユ��_handle_mm_fault��&#65533;&#65533;:
>> > mm/memory.c:3381: error:
>> > 	too many arguments to function
>> ��ユ��rch_vma_access_permitted��&#65533;&#65533;
>> > mm/gup.c: In function ��ユ��heck_vma_flags��&#65533;&#65533;:
>> > mm/gup.c:456: error:
>> > 	too many arguments to function
>> ��ユ��rch_vma_access_permitted��&#65533;&#65533;
>> > mm/gup.c: In function ��ユΣma_permits_fault��&#65533;&#65533;:
>> > mm/gup.c:640: error:
>> > 	too many arguments to function
>> ��ユ��rch_vma_access_permitted��&#65533;&#65533;
>> >
>> > Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate
>> instruction
>> > fetches")
>> > Cc: Dave Hansen <dave.hansen@...ux.intel.com>
>> > Cc: Thomas Gleixner <tglx@...utronix.de>
>> > Cc: Ingo Molnar <mingo@...nel.org>
>> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>>
>> Thanks.
>>
>> Acked-by: Guan Xuetao <gxt@...c.pku.edu.cn>
>>
> Who is going to send the patch upstream ?
>
> Guenter

I will do. Thanks.

Xuetao

>
>> > ---
>> >  arch/unicore32/include/asm/mmu_context.h | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/arch/unicore32/include/asm/mmu_context.h
>> > b/arch/unicore32/include/asm/mmu_context.h
>> > index e35632ef23c7..62dfc644c908 100644
>> > --- a/arch/unicore32/include/asm/mmu_context.h
>> > +++ b/arch/unicore32/include/asm/mmu_context.h
>> > @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct
>> mm_struct
>> > *mm,
>> >  }
>> >
>> >  static inline bool arch_vma_access_permitted(struct vm_area_struct
>> *vma,
>> > -		bool write, bool foreign)
>> > +		bool write, bool execute, bool foreign)
>> >  {
>> >  	/* by default, allow everything */
>> >  	return true;
>> > --
>> > 2.5.0
>> >
>>
>