linux-kernel - Re: [RFC][PATCH v6 1/2] printk: Make printk() completely async

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160324022435.GA25607@swordfish>
Date:	Thu, 24 Mar 2016 11:24:35 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:	Petr Mladek <pmladek@...e.com>
Cc:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jan Kara <jack@...e.com>, Tejun Heo <tj@...nel.org>,
	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
	linux-kernel@...r.kernel.org,
	Byungchul Park <byungchul.park@....com>,
	Jan Kara <jack@...e.cz>
Subject: Re: [RFC][PATCH v6 1/2] printk: Make printk() completely async

On (03/23/16 11:04), Petr Mladek wrote:
[..]
> 					  if (!need_flush_console)
> 					     schedule()
> 
> 					     # did one unnecessary
> 					     # cycle to get asleep

OK. well, didn't consider it to be a problem, but I'll make it
symmetric:
	we set need_flush_console under logbuf lock,
	we clear it under logbuf lock.

should be simpler.

> PS: If you touch the code, please rename printing_func() to
> printk_kthread_func() to make it more clear what it does.

oh, yes, was going to do it but somehow forgot.

	-ss