[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160325143759.GA24596@rob-hp-laptop>
Date: Fri, 25 Mar 2016 09:37:59 -0500
From: Rob Herring <robh@...nel.org>
To: Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc: linux-mtd@...ts.infradead.org,
Graham Moore <grmoore@...nsource.altera.com>,
Dinh Nguyen <dinguyen@...nsource.altera.com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Richard Weinberger <richard@....at>,
Kumar Gala <galak@...eaurora.org>,
Boris Brezillon <boris.brezillon@...e-electrons.com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Brian Norris <computersforpeace@...il.com>,
David Woodhouse <dwmw2@...radead.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH] mtd: nand: denali: allow to override max_banks from DT
property
On Thu, Mar 24, 2016 at 09:24:37PM +0900, Masahiro Yamada wrote:
> Commit 271707b1d817 ("mtd: nand: denali: max_banks calculation
> changed in revision 5.1") supported the new encoding of the "n_banks"
> bits of the "features" register, but there is an unfortunate case
> that is not covered by that commit.
>
> Panasonic (its System LSI division is now Socionext) bought several
> versions of this IP. The IP released for Panasonic around Feb. 2012
> is revision 5 and uses the old encoding for n_banks (2 << n_banks).
> While the one released around Nov. 2012 is also revision 5, but it
> uses the new encoding (1 << n_banks).
>
> The revision register cannot distinguish these two incompatible
> hardware. I guess this IP series is not well-organized. I could not
> find any alternative but giving max_banks from DT property.
>
> This commit works around the problem by allowing DT to set the
> max_banks forcibly. Of course, this DT property can be optional if
> the auto detection based on the hardware registers works well.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
>
> Documentation/devicetree/bindings/mtd/denali-nand.txt | 4 ++++
Acked-by: Rob Herring <robh@...nel.org>
> drivers/mtd/nand/denali.c | 3 ++-
> drivers/mtd/nand/denali_dt.c | 3 +++
> 3 files changed, 9 insertions(+), 1 deletion(-)
Powered by blists - more mailing lists