linux-kernel - Re: [PATCH] regulator: twl: Enable regulators over the powerbus as well

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160325172322.GC5028@sirena.org.uk>
Date:	Fri, 25 Mar 2016 17:23:22 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Sebastian Reichel <sre@...nel.org>
Cc:	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>, tony@...mide.com,
	lgirdwood@...il.com, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: twl: Enable regulators over the powerbus as
 well

On Fri, Mar 25, 2016 at 05:47:50PM +0100, Sebastian Reichel wrote:

> I just tried to describe what's going on, so that you can see the
> whole picture. I don't agree with the patch and think that the mode
> should be switched to normal at probe time. I assumed, that you
> would suggest the correct solution if I describe the problem.

Well, I'm not 100% sure what's going on.  If there is a constraint in
the system that requires setting the mode then something needs to
set that but it sounds like it might be more the case that the mode
support in this driver is just broken at the minute if it's not
orthogonal to the enable support.  Perhaps the mode API is being used
for suspend states or something?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)