linux-kernel - Re: [PATCH] Revert "regulator: core: Add support for active-discharge configuration"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160325181929.GD5028@sirena.org.uk>
Date:	Fri, 25 Mar 2016 18:19:29 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Laxman Dewangan <ldewangan@...dia.com>,
	linux-kernel@...r.kernel.org, Russell King <linux@....linux.org.uk>
Subject: Re: [PATCH] Revert "regulator: core: Add support for
 active-discharge configuration"

On Fri, Mar 25, 2016 at 07:06:21PM +0200, Vladimir Zapolskiy wrote:
> On 25.03.2016 17:45, Mark Brown wrote:

> > Nope, they're patches like other patches.  A big part of what the
> > subject line does is help people work out what they need to look at,
> > something that doesn't pattern match doesn't fulfil that need.

> regarding pattern matching just remove ^ from the regexp and people
> be aware of this "regulator: core" change.

The pattern matching in this case is typically being done by human
beings.

> Please look at 1 hour old 1701f680407c ("Revert "ppdev: use new parport
> device model" ") --- that's IMHO the proper way to create and apply
> reverts.

The fact that a change happens to have been generated with a revert has
no technical impact, you're not communicating with machines here but
rather with people.  Yes, some people don't mind especially if they're
just directly publishing the commit (where it matters much less) but
that doesn't override all other considerations.

> And I disagree with the modified subject and commit message done by you
> and without a notice mentioning this your change in the commit message.

I already published it so it's a bit late now.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)