linux-kernel - Re: [PATCH v2 1/5] drm/rockchip: dw_hdmi: Call drm_encoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56F8D2EE.4080004@rock-chips.com>
Date:	Mon, 28 Mar 2016 14:45:02 +0800
From:	Mark yao <mark.yao@...k-chips.com>
To:	Douglas Anderson <dianders@...omium.org>,
	David Airlie <airlied@...ux.ie>, linux@....linux.org.uk,
	Heiko Stuebner <heiko@...ech.de>
CC:	Daniel Kurtz <djkurtz@...omium.org>,
	linux-rockchip@...ts.infradead.org, john@...ping.me.uk,
	dri-devel@...ts.freedesktop.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup()
 in error path

On 2016年03月08日 06:00, Douglas Anderson wrote:
> The drm_encoder_cleanup() was missing both from the error path of
> dw_hdmi_rockchip_bind().  This caused a crash when slub_debug was
> enabled and we ended up deferring probe of HDMI at boot.
>
> This call isn't needed from unbind() because if dw_hdmi_bind() returns
> no error then it takes over the job of freeing the encoder (in
> dw_hdmi_unbind).
>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

Hi Douglas

it seems has no doubt on these patch, and it works on my board, So I'd 
like to apply following three patches.

[PATCH v2 1/5] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in 
error path
[PATCH v2 3/5] drm/rockchip: vop: Fix vop crtc cleanup
[PATCH v2 4/5] drm/rockchip: dw_hdmi: Don't call platform_set_drvdata()

Thanks for your fixes.

-- Ｍark Yao