linux-kernel - Re: [PATCH v2 2/5] drm/imx: dw_hdmi: Call drm_encoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Vq2JPYxDpa3kH97wnVTTJ-AsyWHQ2nSNSR2sw7aQKwOQ@mail.gmail.com>
Date:	Mon, 28 Mar 2016 08:14:26 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	Russell King <linux@....linux.org.uk>,
	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	Daniel Kurtz <djkurtz@...omium.org>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	John Keeping <john@...ping.me.uk>,
	Douglas Anderson <dianders@...omium.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Mark Yao <mark.yao@...k-chips.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Airlie <airlied@...ux.ie>,
	Heiko Stuebner <heiko@...ech.de>
Subject: Re: [PATCH v2 2/5] drm/imx: dw_hdmi: Call drm_encoder_cleanup() in
 error path

Hi,

On Mon, Mar 7, 2016 at 2:00 PM, Douglas Anderson <dianders@...omium.org> wrote:
> The drm_encoder_cleanup() was missing both from the error path of
> dw_hdmi_imx_bind().  This caused a crash when slub_debug was
> enabled and we ended up deferring probe of HDMI at boot.
>
> This call isn't needed from unbind() because if dw_hdmi_bind() returns
> no error then it takes over the job of freeing the encoder (in
> dw_hdmi_unbind).
>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
> Changes in v2:
> - IMX patch new in v2
>
>  drivers/gpu/drm/imx/dw_hdmi-imx.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)

Mark picked up:

  [PATCH v2 1/5] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path
  [PATCH v2 3/5] drm/rockchip: vop: Fix vop crtc cleanup
  [PATCH v2 4/5] drm/rockchip: dw_hdmi: Don't call platform_set_drvdata()

...for Rockchip, as you can see at
<https://patchwork.kernel.org/patch/8523301/>.

Does someone want to pick up:
  [PATCH v2 2/5] drm/imx: dw_hdmi: Call drm_encoder_cleanup() in error path
  [PATCH v2 5/5] drm/imx: dw_hdmi: Don't call platform_set_drvdata()

Thanks!

-Doug