linux-kernel - RE: [PATCH] usb: host: xhci-plat: Make enum xhci_plat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d1qf80oc.fsf@ti.com>
Date:	Mon, 28 Mar 2016 11:30:11 +0300
From:	Felipe Balbi <balbi@...nel.org>
To:	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Peter Griffin <peter.griffin@...aro.org>
Cc:	Gregory CLEMENT <gregory.clement@...e-electrons.com>,
	"linux-arm-kernel\@lists.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	"mathias.nyman\@intel.com" <mathias.nyman@...el.com>,
	"gregkh\@linuxfoundation.org" <gregkh@...uxfoundation.org>,
	"lee.jones\@linaro.org" <lee.jones@...aro.org>,
	"linux-usb\@vger.kernel.org" <linux-usb@...r.kernel.org>,
	"maxime.coquelin\@st.com" <maxime.coquelin@...com>,
	"patrice.chotard\@st.com" <patrice.chotard@...com>,
	"stable\@vger.kernel.org" <stable@...r.kernel.org>,
	"felipe.balbi\@linux.intel.com" <felipe.balbi@...ux.intel.com>
Subject: RE: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value


Hi,

Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com> writes:
>> > ps: there might be bugs there, but it's a holiday and I really shouldn't
>> > be spending time on this right now ;-)
>> 
>> I'm also off on holiday now until Sunday 10th April... yay :-)
>> >
>> > Anyway, have fun testing. Let me know if it doesn't work.
>> 
>> I only have access to STi platforms which were broken by this change.
>> Not any of the platforms which rely on the functionality which
>> was introduced (although I can't see any reason why your patch wouldn't work).
>> 
>> Maybe Yoshihiro (on CC) could test this on the Renesas platforms and confirm?
>
> Thank you for sending the email to me on CC.
>
> I tested Felipe's patch on Renesas platfroms (R-Car Gen2 and Gen3) and
> I fixed the patch like the following.
>
> However, my fixes patch might need to clean the code up more.
>
> Changes from Felipe's patch:
> - Change function names of xhci_rcar_init_quirk() to xhci_rcar_setup_quirk()

I'm not sure renaming that function fits on the same patch ;-) Sounds
like it should be a separate patch altogether. I'll work on this
tomorrow if it's okay for you guys to test on your respective platforms :-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)