linux-kernel - Re: [PATCH 6/8] iio: adc: Fix at91-sama5d2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56F8EEF1.7020706@kernel.org>
Date:	Mon, 28 Mar 2016 09:44:33 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Richard Weinberger <richard@....at>, linux-kernel@...r.kernel.org
Cc:	linux-iio@...r.kernel.org, Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>,
	Ludovic Desroches <ludovic.desroches@...el.com>
Subject: Re: [PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies

On 25/03/16 22:40, Richard Weinberger wrote:
> Not all archs have io memory.
> 
> Fixes the following build error:
> ERROR: "devm_ioremap_resource" [drivers/iio/adc/at91-sama5d2_adc.ko] undefined!
> 
> Cc: Jonathan Cameron <jic23@...nel.org>
> Cc: Hartmut Knaack <knaack.h@....de>
> Cc: Lars-Peter Clausen <lars@...afoo.de>
> Cc: Peter Meerwald <pmeerw@...erw.net>
> Cc: Ludovic Desroches <ludovic.desroches@...el.com>
> Fixes: b9cd7a25 ("MAINTAINERS: add entry for Atmel SAMA5D2 ADC driver")
> Signed-off-by: Richard Weinberger <richard@....at>
Hi Richard,

I already have a patch queued up covering this, it just hit at exactly the wrong
moment compared to the merge window so hasn't made it upstream yet.

Thanks,

Jonathan
> ---
>  drivers/iio/adc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index af4aea7..31fa2e7 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -133,6 +133,7 @@ config AT91_ADC
>  
>  config AT91_SAMA5D2_ADC
>  	tristate "Atmel AT91 SAMA5D2 ADC"
> +	depends on HAS_IOMEM
>  	depends on ARCH_AT91 || COMPILE_TEST
>  	help
>  	  Say yes here to build support for Atmel SAMA5D2 ADC which is
>