linux-kernel - Re: [PATCH 8/8] iio: imu: Fix inv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56F8F354.3050207@kernel.org>
Date:	Mon, 28 Mar 2016 10:03:16 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Richard Weinberger <richard@....at>, linux-kernel@...r.kernel.org
Cc:	linux-iio@...r.kernel.org, Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>
Subject: Re: [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies

On 25/03/16 22:40, Richard Weinberger wrote:
> Not all archs have io memory.
> Instead of selecting I2C_MUX (and bypassing the HAS_IOMEM dependency)
> depend directly on it.
> 
> Fixes the following kconfig warning:
> warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_I2C) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
> And this build error:
> ERROR: "devm_ioremap_resource" [drivers/i2c/muxes/i2c-mux-reg.ko] undefined!
> ERROR: "of_address_to_resource" [drivers/i2c/muxes/i2c-mux-reg.ko] undefined!
> 
> Cc: Jonathan Cameron <jic23@...nel.org>
> Cc: Hartmut Knaack <knaack.h@....de>
> Cc: Lars-Peter Clausen <lars@...afoo.de>
> Cc: Peter Meerwald <pmeerw@...erw.net>
> Signed-off-by: Richard Weinberger <richard@....at>
Applied to the fixes-togreg-post-rc1 branch of iio.git.

Thanks,

Jonathan
> ---
>  drivers/iio/imu/inv_mpu6050/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/imu/inv_mpu6050/Kconfig b/drivers/iio/imu/inv_mpu6050/Kconfig
> index a7f557a..847455a 100644
> --- a/drivers/iio/imu/inv_mpu6050/Kconfig
> +++ b/drivers/iio/imu/inv_mpu6050/Kconfig
> @@ -9,9 +9,8 @@ config INV_MPU6050_IIO
>  
>  config INV_MPU6050_I2C
>  	tristate "Invensense MPU6050 devices (I2C)"
> -	depends on I2C
> +	depends on I2C_MUX
>  	select INV_MPU6050_IIO
> -	select I2C_MUX
>  	select REGMAP_I2C
>  	help
>  	  This driver supports the Invensense MPU6050 devices.
>