linux-kernel - Re: (mostly) Arch-independent livepatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160329211330.GA1253@packer-debian-8-amd64.digitalocean.com>
Date:	Tue, 29 Mar 2016 17:13:30 -0400
From:	Jessica Yu <jeyu@...hat.com>
To:	Rusty Russell <rusty@...tcorp.com.au>,
	Josh Poimboeuf <jpoimboe@...hat.com>,
	Petr Mladek <pmladek@...e.com>, Jiri Kosina <jikos@...nel.org>,
	Jonathan Corbet <corbet@....net>,
	Miroslav Benes <mbenes@...e.cz>
Cc:	linux-api@...r.kernel.org, live-patching@...r.kernel.org,
	x86@...nel.org, linux-kernel@...r.kernel.org,
	linux-s390@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: (mostly) Arch-independent livepatch

+++ Jessica Yu [22/03/16 20:03 -0400]:
>
>Patches based on linux-next.
>
>Previous patchset (v5) found here:
>http://lkml.kernel.org/g/1458157628-8264-1-git-send-email-jeyu@redhat.com
>
>v6:
> - Since we hard-code the field widths for the objname and symbol name
>   for the sscanf() calls, which are supposed to correspond to the values
>   of MODULE_NAME_LEN and KSYM_NAME_LEN, use BUILD_BUG_ON() to detect when
>   the values of these constants deviate from the expected values.
> - Squash the sample livepatch module patch into patch 4
>   ("livepatch: reuse module loader code to write relocations") so
>   git bisects don't break
> - Don't need the klp_buf struct, just use plain char arrays to hold the
>   output of sscanf(). Also, no need to clear the bufs after every
>   invocation, as sscanf() takes care to put a null byte at the end of
>   the bufs.
> - Fix compiler kbuild errors for the !CONFIG_LIVEPATCH case
> - Fixed some small module.c nits
>

Pinging Rusty, just in case this thread got buried :-)
How do the module.c changes look?

Thanks,
Jessica