linux-kernel - Re: (mostly) Arch-independent livepatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1603300122020.3656@cbobk.fhfr.pm>
Date:	Wed, 30 Mar 2016 01:24:08 +0200 (CEST)
From:	Jiri Kosina <jikos@...nel.org>
To:	Jessica Yu <jeyu@...hat.com>
cc:	Rusty Russell <rusty@...tcorp.com.au>,
	Josh Poimboeuf <jpoimboe@...hat.com>,
	Petr Mladek <pmladek@...e.com>,
	Jonathan Corbet <corbet@....net>,
	Miroslav Benes <mbenes@...e.cz>, linux-api@...r.kernel.org,
	live-patching@...r.kernel.org, x86@...nel.org,
	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
	linux-doc@...r.kernel.org,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>
Subject: Re: (mostly) Arch-independent livepatch

On Tue, 29 Mar 2016, Jessica Yu wrote:

> > v6:
> > - Since we hard-code the field widths for the objname and symbol name
> >   for the sscanf() calls, which are supposed to correspond to the values
> >   of MODULE_NAME_LEN and KSYM_NAME_LEN, use BUILD_BUG_ON() to detect when
> >   the values of these constants deviate from the expected values.
> > - Squash the sample livepatch module patch into patch 4
> >   ("livepatch: reuse module loader code to write relocations") so
> >   git bisects don't break
> > - Don't need the klp_buf struct, just use plain char arrays to hold the
> >   output of sscanf(). Also, no need to clear the bufs after every
> >   invocation, as sscanf() takes care to put a null byte at the end of
> >   the bufs.
> > - Fix compiler kbuild errors for the !CONFIG_LIVEPATCH case
> > - Fixed some small module.c nits
> > 
> 
> Pinging Rusty, just in case this thread got buried :-)
> How do the module.c changes look?

Plus there are (admittedly indeed rather small and trivial) changes to 
s390 module loader, so I'd prefer to have Heiko's / Martin's Ack before 
merging this.

Hence, let me piggy back on this ping to Rusty, and let me ping Heiko and 
Martin as well (adding to CC explicitly to make sure this doesn't get lost 
in general noise).

Thanks,

-- 
Jiri Kosina
SUSE Labs