linux-kernel - Re: [PATCH] regulator: qcom_spmi: Add slewing delays for all SMPS types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160329230931.GT2350@sirena.org.uk>
Date:	Tue, 29 Mar 2016 16:09:31 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Stephen Boyd <stephen.boyd@...aro.org>
Cc:	linux-arm@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org,
	Georgi Djakov <georgi.djakov@...aro.org>,
	David Collins <collinsd@...eaurora.org>
Subject: Re: [PATCH] regulator: qcom_spmi: Add slewing delays for all SMPS
 types

On Tue, Mar 29, 2016 at 03:58:40PM -0700, Stephen Boyd wrote:

> -	if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS) {
> -		ret = spmi_regulator_ftsmps_init_slew_rate(vreg);
> +	if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS ||
> +	    vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_ULT_LO_SMPS ||
> +	    vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_ULT_HO_SMPS ||
> +	    vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_SMPS) {
> +		ret = spmi_regulator_init_slew_rate(vreg);

This should be a switch statement.  Otherwise this looks fine.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)