linux-kernel - Re: [PATCH] regulator: qcom_spmi: Add slewing delays for all SMPS types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56FBE45B.4030709@linaro.org>
Date:	Wed, 30 Mar 2016 17:36:11 +0300
From:	Georgi Djakov <georgi.djakov@...aro.org>
To:	Stephen Boyd <stephen.boyd@...aro.org>,
	Mark Brown <broonie@...nel.org>
Cc:	linux-arm@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org,
	David Collins <collinsd@...eaurora.org>
Subject: Re: [PATCH] regulator: qcom_spmi: Add slewing delays for all SMPS
 types

On 03/30/2016 01:58 AM, Stephen Boyd wrote:
> Only the FT SMPS type regulators have slewing supported in the
> driver, but all types of SMPS regulators need the same support.
> The only difference is that some SMPS regulators don't have a
> step size and the step delay is typically 20, not 8. Luckily, the
> step size reads as 0 for the non-FT types, so we can always read
> that, but we need to detect which type of regulator we're using
> to figure out what step delay to use. Make these minor
> adjustments to the slew rate calculations and add support for the
> delay function to the appropriate regulator ops.
> 
> Reported-by: Georgi Djakov <georgi.djakov@...aro.org>
> Cc: David Collins <collinsd@...eaurora.org>
> Signed-off-by: Stephen Boyd <stephen.boyd@...aro.org>

Thanks for the patch! I have verified it by applying this one
on top: https://lkml.org/lkml/2016/3/30/381

Tested-by: Georgi Djakov <georgi.djakov@...aro.org>

BR,
Georgi