linux-kernel - Re: [PATCH 15/16] wcn36xx: don't pad beacons for mesh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56FA7905.80902@cogentembedded.com>
Date:	Tue, 29 Mar 2016 15:45:57 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Bjorn Andersson <bjorn.andersson@...aro.org>,
	Eugene Krasnikov <k.eugene.e@...il.com>,
	Kalle Valo <kvalo@...eaurora.org>
Cc:	wcn36xx@...ts.infradead.org, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jason Mobarak <jam@...ybit.com>,
	Chun-Yeow Yeoh <yeohchunyeow@...ybit.com>
Subject: Re: [PATCH 15/16] wcn36xx: don't pad beacons for mesh

Hello.

On 3/29/2016 9:06 AM, Bjorn Andersson wrote:

> From: Jason Mobarak <jam@...ybit.com>
>
> Patch "wcn36xx: Pad TIM PVM if needed" has caused a regression in mesh

    scripts/checkpatch.pl now enforces the specific commit citing format, i.e. 
<12-digit SHA1> ("<commit summary>").

> beaconing.  The field tim_off is always 0 for mesh mode, and thus
> pvm_len (referring to the TIM length field) and pad are both incorrectly
> calculated.  Thus, msg_body.beacon_length is incorrectly calculated for
> mesh mode. Fix this.
>
> Signed-off-by: Jason Mobarak <jam@...ybit.com>
> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@...ybit.com>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>

    You might want to add the Fixes: tag.

[...]

MBR, Sergei