linux-kernel - Re: [PATCH 0/3 v5] drm: Introduce drm_connector_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1459255601.3021.37.camel@synopsys.com>
Date:	Tue, 29 Mar 2016 12:46:41 +0000
From:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>
To:	"boris.brezillon@...e-electrons.com" 
	<boris.brezillon@...e-electrons.com>
CC:	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"daniel@...ll.ch" <daniel@...ll.ch>,
	"laurent.pinchart@...asonboard.com" 
	<laurent.pinchart@...asonboard.com>,
	"linux-renesas-soc@...r.kernel.org" 
	<linux-renesas-soc@...r.kernel.org>,
	"airlied@...ux.ie" <airlied@...ux.ie>,
	"dh.herrmann@...il.com" <dh.herrmann@...il.com>
Subject: Re: [PATCH 0/3 v5] drm: Introduce drm_connector_register_all()
 helper

Hi Boris,

On Tue, 2016-03-29 at 14:43 +0200, Boris Brezillon wrote:
> Hi Alexey,
> 
> On Tue, 29 Mar 2016 13:22:49 +0300
> Alexey Brodkin <Alexey.Brodkin@...opsys.com> wrote:
> 
> > 
> > As a pair to already existing drm_connector_unplug_all()
> > (which we'll rename in this series to drm_connector_unregister_all())
> > we're adding generic implementation of what is already done in some drivers
> > for registering all connectors.
> > 
> > After implementation of that new helper we're updating 2 drivers
> > that used to use it's own implementation:
> >  [1] atmel_hlcdc
> >  [2] rcar_du
> > 
> > Other drivers still use load() callback and so should be first modified so
> > their load() gets called from their probe() explicitly.
> > 
> > Build- and run-tested on yet to be upstreamed ARC PGU (part of AXS10x board).
> > 
> > Changes v4 -> v5:
> >  * Added missing mutex unlock on a fail path in drm_connector_register_all()
> >    Thanks David for his attention and patience!
> > 
> > Changes v3 -> v4:
> >  * Based on current drm-intel/topic/drm-misc
> >    It's now on commit 6c87e5c3ec6db052f3744804a517b6fb003906e1
> >    And since thet new base already has
> >    "drm: Rename drm_connector_unplug_all() to drm_connector_unregister_all()"
> >    this series now only includes 3 subsequent patches.
> > 
> >  * In drm_connector_register_all() fail path which calls unregister_all()
> >    is moved outside of loop&locked section (as suggested by Daniel)
> > 
> > Changes v2 -> v3:
> >  * Added acks for 1, 3 and 4 patches
> >  * Updated kerneldoc descriptins of both register_ and unregister_all()
> >  * Updated commit messages (mostly spellos and grammar issues)
> > 
> > Changes v1 -> v2:
> >  * Rename drm_connector_unplug_all() to drm_connector_unregister_all()
> >  * Use drm_for_each_connector() instead of list_for_each_entry()
> >  * Updated kerneldoc for drm_dev_register()
> > 
> > Cc: Daniel Vetter <daniel@...ll.ch>
> > Cc: David Airlie <airlied@...ux.ie>
> > Cc: Boris Brezillon <boris.brezillon@...e-electrons.com>
> Next time, can you please send all the patches of the series, not
> only the cover letter.

Sure.

It would be so much more convenient if git may add all people mentioned
in any patch of series to Cc list for all other patches (+ cover letter).
Without that feature one has to add all people in Cc explicitly in each patch.

-Alexey