linux-kernel - Re: [PATCH 11/12] ARM: dts: dragonboard-600c: add i2c support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Mar 2016 07:44:37 -0700
From:	Bjorn Andersson <bjorn.andersson@...aro.org>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:	Andy Gross <andy.gross@...aro.org>, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-soc@...r.kernel.org
Subject: Re: [PATCH 11/12] ARM: dts: dragonboard-600c: add i2c support

On Wed 23 Mar 12:48 PDT 2016, Srinivas Kandagatla wrote:

> This patch adds nodes required to enable 4 i2c buses on the board which
> are connected to various sensors and eeprom.
> 

I would like for the pinconf for these blocks to be in this patch (and
file) to make it clear how they are configured and where to change them.

Regards,
Bjorn

> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
>  .../arm/boot/dts/qcom-apq8064-dragonboard-600c.dts | 46 ++++++++++++++++++++++
>  1 file changed, 46 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts b/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts
> index 4fecd94..942de04 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts
> @@ -8,6 +8,10 @@
>  	aliases {
>  		serial0 = &gsbi7_serial;
>  		serial1 = &gsbi1_serial;
> +		i2c0 = &gsbi2_i2c;
> +		i2c1 = &gsbi3_i2c;
> +		i2c2 = &gsbi4_i2c;
> +		i2c3 = &gsbi7_i2c;
>  	};
>  
>  	regulators {
> @@ -180,6 +184,42 @@
>  			};
>  		};
>  
> +		gsbi@...80000 {
> +			status = "okay";
> +			qcom,mode = <GSBI_PROT_I2C>;
> +			i2c@...a0000 {
> +				/* On Low speed expansion and Sensors */
> +				label = "LS-I2C0";
> +				status = "okay";
> +			};
> +		};
> +
> +		gsbi@...00000 {
> +			status = "okay";
> +			qcom,mode = <GSBI_PROT_I2C>;
> +			i2c@...80000 {
> +			/* On Low speed expansion */
> +				status = "okay";
> +				label = "LS-I2C1";
> +				clock-frequency = <200000>;
> +				eeprom@52 {
> +					compatible = "atmel,24c128";
> +					reg = <0x52>;
> +					pagesize = <64>;
> +				};
> +			};
> +		};
> +
> +		gsbi@...00000 {
> +			status = "okay";
> +			qcom,mode = <GSBI_PROT_I2C>;
> +			i2c@...80000 {
> +				/* On High speed expansion */
> +				label = "HS-CAM-I2C3";
> +				status = "okay";
> +			};
> +		};
> +
>  		/* DEBUG UART  */
>  		gsbi@...00000 {
>  			status = "okay";
> @@ -190,6 +230,12 @@
>  				pinctrl-names = "default";
>  				pinctrl-0 = <&gsbi7_uart_2pins>;
>  			};
> +
> +			i2c@...80000 {
> +				/* On High speed expansion */
> +				status = "okay";
> +				label = "HS-CAM-I2C2";
> +			};
>  		};
>  
>  		leds {
> -- 
> 2.5.0
>