linux-kernel - Re: [PATCH v3 1/2] dmaengine: vdma: Add 64 bit addressing support to the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160329185531.GA19517@rob-hp-laptop>
Date:	Tue, 29 Mar 2016 13:55:31 -0500
From:	Rob Herring <robh@...nel.org>
To:	Kedareswara rao Appana <appana.durga.rao@...inx.com>
Cc:	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	michal.simek@...inx.com, soren.brinkmann@...inx.com,
	vinod.koul@...el.com, dan.j.williams@...el.com,
	anuragku@...inx.com, appanad@...inx.com, moritz.fischer@...us.com,
	laurent.pinchart@...asonboard.com, luis@...ethencourt.com,
	svemula@...inx.com, anirudh@...inx.com, dmaengine@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 1/2] dmaengine: vdma: Add 64 bit addressing support to
 the driver

On Fri, Mar 25, 2016 at 02:46:18PM +0530, Kedareswara rao Appana wrote:
> This VDMA  is a soft ip, which can be programmed to support
> 32 bit addressing or greater than 32 bit addressing.
> 
> When the VDMA ip is configured for 32 bit address space
> the buffer address is specified by a single register
> (0x5C for MM2S and 0xAC for S2MM channel).
> 
> When the  VDMA core is configured for an address space greater
> than 32 then each buffer address is specified by a combination of
> two registers.
> 
> The first register specifies the LSB 32 bits of address,
> while the next register specifies the MSB 32 bits of address.
> 
> For example, 5Ch will specify the LSB 32 bits while 60h will
> specify the MSB 32 bits of the first start address.
> So we need to program two registers at a time.
> 
> This patch adds the 64 bit addressing support to the vdma driver.
> 
> Signed-off-by: Anurag Kumar Vulisha <anuragku@...inx.com>
> Signed-off-by: Kedareswara rao Appana <appanad@...inx.com>
> ---
> Changes for v3:
> --> Improved commit message as suggested by vinod.
> --> removed unnecessary braces for single line if conditions.
> Changes for v2:
> ---> Added dma-ranges property in device tree as suggested by Arnd Bergmann.
> ---> Added device tree property(xlnx,addrwidth) for an identification of whether
>      the IP block itself is configured in 64-bit or 32-bit mode as suggested by
>      Laurent Pinchart.
> ---> Modified the driver code based on the xlnx,addrwidth.
> 
>  .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt |  4 ++
>  drivers/dma/Kconfig                                |  2 +-
>  drivers/dma/xilinx/xilinx_vdma.c                   | 73 +++++++++++++++++++---
>  3 files changed, 70 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> index e4c4d47..a86737c 100644
> --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> @@ -8,6 +8,8 @@ Required properties:
>  - #dma-cells: Should be <1>, see "dmas" property below
>  - reg: Should contain VDMA registers location and length.
>  - xlnx,num-fstores: Should be the number of framebuffers as configured in h/w.
> +- xlnx,addrwidth: Should be the vdma addressing size in bits(ex: 32 bits).
> +- dma-ranges: Should be as the following <dma_addr cpu_addr max_len>.

Doesn't the log2 of the dma-ranges size provide you with the address 
width?

>  - dma-channel child node: Should have at least one channel and can have up to
>  	two channels per device. This node specifies the properties of each
>  	DMA channel (see child node properties below).
> @@ -41,8 +43,10 @@ axi_vdma_0: axivdma@...30000 {
>  	compatible = "xlnx,axi-vdma-1.00.a";
>  	#dma_cells = <1>;
>  	reg = < 0x40030000 0x10000 >;
> +	dma-ranges = <0x00000000 0x00000000 0x40000000>;
>  	xlnx,num-fstores = <0x8>;
>  	xlnx,flush-fsync = <0x1>;
> +	xlnx,addrwidth = <0x20>;
>  	dma-channel@...30000 {
>  		compatible = "xlnx,axi-vdma-mm2s-channel";
>  		interrupts = < 0 54 4 >;