linux-kernel - Re: [PATCH] HID: multitouch: Synchronize MT frame on reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANLzEkv1gLe2Ay2OQLbgSOoYU9Ar1VN_xT7fAkzD=1QNYXjm7Q@mail.gmail.com>
Date:	Tue, 29 Mar 2016 13:36:11 -0700
From:	Benson Leung <bleung@...omium.org>
To:	Gabriele Mazzotta <gabriele.mzt@...il.com>
Cc:	Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dmitry Torokhov <dtor@...omium.org>
Subject: Re: [PATCH] HID: multitouch: Synchronize MT frame on reset_resume

Hi Gabriele,

Thanks for the fix!

On Tue, Mar 29, 2016 at 1:10 PM, Gabriele Mazzotta
<gabriele.mzt@...il.com> wrote:
> input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called
> at each frame. Do it when releasing the touches, or else we won't get
> a proper slot number after mt_reset_resume().
>
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@...il.com>

Reviewed-by: Benson Leung <bleung@...omium.org>

> ---
>  drivers/hid/hid-multitouch.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 25d3c43..c741f5e 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -1169,6 +1169,7 @@ static void mt_release_contacts(struct hid_device *hid)
>                                                            MT_TOOL_FINGER,
>                                                            false);
>                         }
> +                       input_mt_sync_frame(input_dev);
>                         input_sync(input_dev);
>                 }
>         }
> --
> 2.8.0.rc3
>



-- 
Benson Leung
Senior Software Engineer, Chrom* OS
bleung@...omium.org