linux-kernel - Re: [PATCH] HID: multitouch: Synchronize MT frame on reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160330074628.GE20424@mail.corp.redhat.com>
Date:	Wed, 30 Mar 2016 09:46:28 +0200
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	Gabriele Mazzotta <gabriele.mzt@...il.com>
Cc:	jikos@...nel.org, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, bleung@...omium.org
Subject: Re: [PATCH] HID: multitouch: Synchronize MT frame on reset_resume

On Mar 29 2016 or thereabouts, Gabriele Mazzotta wrote:
> input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called
> at each frame. Do it when releasing the touches, or else we won't get
> a proper slot number after mt_reset_resume().
> 
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@...il.com>

Thanks for the fix (I should have spot that earlier :( )

Reviewed-by: Benjamin TIssoires <benjamin.tissoires@...hat.com>

Cheers,
Benjamin

> ---
>  drivers/hid/hid-multitouch.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 25d3c43..c741f5e 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -1169,6 +1169,7 @@ static void mt_release_contacts(struct hid_device *hid)
>  							   MT_TOOL_FINGER,
>  							   false);
>  			}
> +			input_mt_sync_frame(input_dev);
>  			input_sync(input_dev);
>  		}
>  	}
> -- 
> 2.8.0.rc3
>