linux-kernel - Re: [RESEND v2] phy: hi6220: Add missing MFD_SYSCON dependency on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160330080837.GA3323@x1>
Date:	Wed, 30 Mar 2016 09:08:37 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Kishon Vijay Abraham I <kishon@...com>,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND v2] phy: hi6220: Add missing MFD_SYSCON dependency on
 HAS_IOMEM

On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote:

> The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet
> direct dependencies.
> 
> This fixes warning on allyesconfig on ARCH=um:
> 
> warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X &&
> 	DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW
> 	&& PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE &&
> 	S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK &&
> 	RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM &&
> 	ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB)
> selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Acked-by: Lee Jones <lee.jones@...aro.org>

Holding off on this until the discussion reaches some kind of
consensus.

> ---
> 
> Changes since v1:
> 1. Remove the comment why HAS_IOMEM dependency was added.
> 2. Exdended description.
> ---
>  drivers/phy/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 879ac798f6f7..17e5f5c7ffff 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -226,6 +226,7 @@ config PHY_MT65XX_USB3
>  config PHY_HI6220_USB
>  	tristate "hi6220 USB PHY support"
>  	depends on (ARCH_HISI && ARM64) || COMPILE_TEST
> +	depends on HAS_IOMEM
>  	select GENERIC_PHY
>  	select MFD_SYSCON
>  	help

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog