linux-kernel - Re: [RESEND] phy: Fix build error of missing devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160330080856.GB3323@x1>
Date:	Wed, 30 Mar 2016 09:08:56 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Kishon Vijay Abraham I <kishon@...com>,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource
 on UM

On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote:

> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um
> allyesconfig (COMPILE_TEST) failed with:
> 
> drivers/built-in.o: In function `omap_control_phy_probe':
> phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource'
> drivers/built-in.o: In function `cygnus_pcie_phy_probe':
> phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource'
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> ---
>  drivers/phy/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)

Holding off on this until the discussion reaches some kind of
consensus.

> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 26566db09de0..879ac798f6f7 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -128,6 +128,7 @@ config PHY_RCAR_GEN3_USB2
>  config OMAP_CONTROL_PHY
>  	tristate "OMAP CONTROL PHY Driver"
>  	depends on ARCH_OMAP2PLUS || COMPILE_TEST
> +	depends on HAS_IOMEM
>  	help
>  	  Enable this to add support for the PHY part present in the control
>  	  module. This driver has API to power on the USB2 PHY and to write to
> @@ -415,6 +416,7 @@ config PHY_BRCMSTB_SATA
>  config PHY_CYGNUS_PCIE
>  	tristate "Broadcom Cygnus PCIe PHY driver"
>  	depends on OF && (ARCH_BCM_CYGNUS || COMPILE_TEST)
> +	depends on HAS_IOMEM
>  	select GENERIC_PHY
>  	default ARCH_BCM_CYGNUS
>  	help

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog