linux-kernel - Re: [PATCH 1/3 v2] drm/i2c/adv7511: Add audio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACvgo53rc2DhQdJUZJB5Lsj57vJGytU7GKqp-O_YZvzH7Df1XA@mail.gmail.com>
Date:	Wed, 30 Mar 2016 10:58:42 +0100
From:	Emil Velikov <emil.l.velikov@...il.com>
To:	Jose Abreu <Jose.Abreu@...opsys.com>
Cc:	linux-snps-arc@...ts.infradead.org,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	ML dri-devel <dri-devel@...ts.freedesktop.org>,
	alsa-devel@...a-project.org,
	devicetree <devicetree@...r.kernel.org>,
	Jon Medhurst <tixy@...aro.org>,
	Mark Rutland <mark.rutland@....com>, broonie@...nel.org,
	Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
	lgirdwood@...il.com, yitian.bu@...gramtek.com,
	wsa+renesas@...g-engineering.com,
	laurent.pinchart+renesas@...asonboard.com,
	nariman@...nsource.wolfsonmicro.com, Maruthi.Bayyavarapu@....com,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Vineet.Gupta1@...opsys.com, buyitian@...il.com, perex@...ex.cz,
	tiwai@...e.com, Rob Herring <robh+dt@...nel.org>,
	Kumar Gala <galak@...eaurora.org>,
	Alex Deucher <alexander.deucher@....com>,
	CARLOS.PALMINHA@...opsys.com
Subject: Re: [PATCH 1/3 v2] drm/i2c/adv7511: Add audio support

Hi Jose,

On 28 March 2016 at 15:36, Jose Abreu <Jose.Abreu@...opsys.com> wrote:
> This patch adds audio support for the ADV7511 HDMI transmitter
> using ALSA SoC.
>
> The code was ported from Analog Devices linux tree from
> commit 1770c4a1e32b ("Merge remote-tracking branch
> 'xilinx/master' into xcomm_zynq"), which is available at:
>         - https://github.com/analogdevicesinc/linux/
>
> The main core file was renamed from adv7511.c to adv7511_core.c
> so that audio and video compile into a single adv7511.ko module
> and to keep up with Analog Devices kernel tree.
>
> The audio can be disabled using menu-config so it is possible
> to use only video mode.
>
> The HDMI mode is automatically started at boot and the audio
> (when enabled) registers as a codec into ALSA.
>
> SPDIF DAI format was also added to ASoC as it is required
> by adv7511 audio.
>
> Signed-off-by: Jose Abreu <joabreu@...opsys.com>
> ---
>
> No changes v1 -> v2.
>
>  drivers/gpu/drm/i2c/Kconfig         |   11 +
>  drivers/gpu/drm/i2c/Makefile        |    2 +
>  drivers/gpu/drm/i2c/adv7511.c       | 1024 -----------------------------------
>  drivers/gpu/drm/i2c/adv7511.h       |   41 ++
>  drivers/gpu/drm/i2c/adv7511_audio.c |  310 +++++++++++
>  drivers/gpu/drm/i2c/adv7511_core.c  | 1005 ++++++++++++++++++++++++++++++++++
Please keep the file rename separate (and use -M flag when generating
the patch) from the introduction of audio support. Having to check 1k
LOC movement alongside the introduction of new one is a bit...
suboptimal.

Regards,
Emil