linux-kernel - Re: [PATCH v2 1/6] pinctrl: baytrail: Add pin control data structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160330111501.GS2099@lahna.fi.intel.com>
Date:	Wed, 30 Mar 2016 14:15:01 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	Cristina Ciocan <cristina.ciocan@...el.com>
Cc:	mathias.nyman@...ux.intel.com, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, irina.tirdea@...el.com,
	octavian.purdila@...el.com
Subject: Re: [PATCH v2 1/6] pinctrl: baytrail: Add pin control data structures

On Mon, Mar 28, 2016 at 04:29:35PM +0300, Cristina Ciocan wrote:
> +/* SCORE pins */
> +static const struct pinctrl_pin_desc byt_score_pins[] = {
> +	PINCTRL_PIN(0, "SATA_GP[0]"),		/* GPIOC_0 */
> +	PINCTRL_PIN(1, "SATA_GP[1]"),		/* GPIOC_1 */

Maybe we should call these "SATA_GP0" and "SATA_GP1" like we do in other
Intel pinctrl drivers?

Also I don't think /* GPIOC_1 */ is really useful comment as that can be
derived already from the pin number.

Otherwise this looks good.