linux-kernel - Re: [PATCH] cpufreq: acpi: policy->driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gyndbTjEYvS8BjZzC-jsKc_M2w9BZF=z-tjEVqMxqFog@mail.gmail.com>
Date:	Wed, 30 Mar 2016 13:18:08 +0200
From:	"Rafael J. Wysocki" <rafael@...nel.org>
To:	"Rafael J. Wysocki" <rafael@...nel.org>
Cc:	Viresh Kumar <viresh.kumar@...aro.org>,
	Rafael Wysocki <rjw@...ysocki.net>,
	Lists linaro-kernel <linaro-kernel@...ts.linaro.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: acpi: policy->driver_data can't be NULL in ->exit()

On Wed, Mar 30, 2016 at 1:15 PM, Rafael J. Wysocki <rafael@...nel.org> wrote:
> On Wed, Mar 30, 2016 at 6:24 AM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
>> Its always set by ->init() and so it will always be there in ->exit().
>> There is no need to have a special check for just that.
>
> I'm not sure what happens if there are two (or more) CPUs in the policy, though.
>
> That case is almost certainly handled incorrectly here (or rather not
> handled at all), but it may just happen to sort of work, because the
> first exiting CPU will clear driver_data and the second one will
> notice that it is NULL now.  Of course, that still is racy with
> respect to governors etc, but I'd rather fix the driver properly.

Sorry, scratch that.  To core only calls ->exit for the last CPU in
the policy, so I agree with the patch.

It conflicts with other stuff (as you know), so I'm not sure about the
order in which they are going to be applied, though.

Thanks,
Rafael