linux-kernel - Re: [PATCH] block: partition: initialize percpuref before sending out KOBJ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160330174310.GA9544@infradead.org>
Date:	Wed, 30 Mar 2016 10:43:10 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Ming Lei <ming.lei@...onical.com>
Cc:	Jens Axboe <axboe@...com>, linux-kernel@...r.kernel.org,
	linux-block@...r.kernel.org, Christoph Hellwig <hch@...radead.org>,
	Naveen Kaje <nkaje@...eaurora.org>, stable@...r.kernel.org
Subject: Re: [PATCH] block: partition: initialize percpuref before sending
 out KOBJ_ADD

> +	if (err) {
> +		if (flags & ADDPART_FLAG_WHOLEDISK)
> +			goto out_remove_file;
> +		goto out_del;
> +	}

I'd rather have that if around the actual device_remove_file at the
label, and jump to out_remove_file unconditionally.

Otherwise this looks fine to me.