linux-kernel - Re: [PATCH] elevator: remove second argument in elevator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56FC7098.1050503@kernel.dk>
Date:	Wed, 30 Mar 2016 18:34:32 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Alexey Klimov <klimov.linux@...il.com>, linux-block@...r.kernel.org
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jeff Moyer <jmoyer@...hat.com>,
	Yury Norov <yury.norov@...il.com>
Subject: Re: [PATCH] elevator: remove second argument in elevator_init()

On 03/30/2016 05:31 PM, Alexey Klimov wrote:
> Hi all,
>
> On Wed, Jan 27, 2016 at 9:01 PM, Jeff Moyer <jmoyer@...hat.com> wrote:
>> Alexey Klimov <klimov.linux@...il.com> writes:
>>
>>> Last user of elevator_init() with non-NULL name as second argument
>>> that supposed to be s390 dasd driver has gone few releases ago.
>>> Drivers rely on elevator_change(), elevator_switch() and friends
>>> for example. Right now elevator_init() is always called as
>>> elevator_init(q, NULL).
>>>
>>> Patch removes passing of second name argument and its usage.
>>>
>>> While we're at it fix following if-check after removed lines. We know
>>> that elevator_type e is initialized by NULL and need to check only
>>> chosen_elevator.
>>>
>>> Signed-off-by: Alexey Klimov <klimov.linux@...il.com>
>>
>> Reviewed-by: Jeff Moyer <jmoyer@...hat.com>
>
>
> what is the status of this patch? Is it that wrong and are there some
> concerns or do I need to resend it?

It looks fine, I'll pick it up for 4.7.

-- 
Jens Axboe