linux-kernel - Re: [PATCH] ACPICA: Remove unnecessary "\n" from an ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56FC7941.2080202@redhat.com>
Date:	Wed, 30 Mar 2016 22:11:29 -0300
From:	Daniel Bristot de Oliveira <bristot@...hat.com>
To:	"Moore, Robert" <robert.moore@...el.com>,
	"Zheng, Lv" <lv.zheng@...el.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	Len Brown <lenb@...nel.org>
Cc:	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"devel@...ica.org" <devel@...ica.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPICA: Remove unnecessary "\n" from an ACPI_INFO boot
 message

On 03/29/2016 04:09 PM, Moore, Robert wrote:
> Actually, I did in fact put that there to break up the output after the tables are loaded. Is this a problem?

Well, I do not believe that there is a real problem on it.

On the other hand, it does not seem to be common to have blank lines in
the kernel log, and as there is no info about from where the black line
comes from, it does not even seems to be connected to the previous
message. So although my patch is about "cosmetics", IMHO it is worth as
pattern or best practices. Feel free to reject if it is not the case, np
:-).

-- Daniel