linux-kernel - RE: [PATCH] ACPICA: Remove unnecessary "\n" from an ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37E455538@ORSMSX110.amr.corp.intel.com>
Date:	Tue, 29 Mar 2016 19:09:57 +0000
From:	"Moore, Robert" <robert.moore@...el.com>
To:	Daniel Bristot de Oliveira <bristot@...hat.com>,
	"Zheng, Lv" <lv.zheng@...el.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	"Len Brown" <lenb@...nel.org>
CC:	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"devel@...ica.org" <devel@...ica.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ACPICA: Remove unnecessary "\n" from an ACPI_INFO boot
 message

Actually, I did in fact put that there to break up the output after the tables are loaded. Is this a problem?


> -----Original Message-----
> From: Daniel Bristot de Oliveira [mailto:bristot@...hat.com]
> Sent: Monday, March 28, 2016 10:59 AM
> To: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown
> Cc: linux-acpi@...r.kernel.org; devel@...ica.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH] ACPICA: Remove unnecessary "\n" from an ACPI_INFO boot
> message
> 
> A "\n" at the end of bellow ACPI_INFO message is causing a blank line in
> the kernel log:
> 
>   ACPI_INFO(("%u ACPI AML tables successfully acquired and loaded\n",
> tables_loaded));
> 
> This patch removes the "\n".
> 
> Kernel log before this patch:
> 	ACPI: Core revision 20160108
> 	ACPI: 2 ACPI AML tables successfully acquired and loaded
> 
> 	Security Framework initialized
> 
> Kernel log after this patch:
> 	ACPI: Core revision 20160108
> 	ACPI: 2 ACPI AML tables successfully acquired and loaded
> 	Security Framework initialized
> 
> Signed-off-by: Daniel Bristot de Oliveira <bristot@...hat.com>
> 
> diff --git a/drivers/acpi/acpica/tbxfload.c
> b/drivers/acpi/acpica/tbxfload.c index 3151968..e435b84 100644
> --- a/drivers/acpi/acpica/tbxfload.c
> +++ b/drivers/acpi/acpica/tbxfload.c
> @@ -240,7 +240,8 @@ acpi_status acpi_tb_load_namespace(void)
>  	}
> 
>  	if (!tables_failed) {
> -		ACPI_INFO(("%u ACPI AML tables successfully acquired and
> loaded\n", tables_loaded));
> +		ACPI_INFO(("%u ACPI AML tables successfully acquired and
> loaded",
> +			   tables_loaded));
>  	} else {
>  		ACPI_ERROR((AE_INFO,
>  			    "%u table load failures, %u successful",
> --
> 2.5.0