lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 31 Mar 2016 11:04:34 +0300 From: Mika Westerberg <mika.westerberg@...ux.intel.com> To: Cristina Ciocan <cristina.ciocan@...el.com> Cc: mathias.nyman@...ux.intel.com, heikki.krogerus@...ux.intel.com, linus.walleij@...aro.org, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, irina.tirdea@...el.com, octavian.purdila@...el.com Subject: Re: [PATCH v3 1/6] pinctrl: baytrail: Add pin control data structures On Wed, Mar 30, 2016 at 06:05:30PM +0300, Cristina Ciocan wrote: > + PINCTRL_PIN(55, "GPIO_S0_SC[055]"), > + PINCTRL_PIN(56, "GPIO_S0_SC[056]"), > + PINCTRL_PIN(57, "GPIO_S0_SC[057]"), > + PINCTRL_PIN(58, "GPIO_S0_SC[058]"), > + PINCTRL_PIN(59, "GPIO_S0_SC[059]"), > + PINCTRL_PIN(60, "GPIO_S0_SC[060]"), > + PINCTRL_PIN(61, "GPIO_S0_SC[061]"), You still have these (and all similar [number]) things. IMO this looks better: PINCTRL_PIN(55, "GPIO_S0_SC55"), PINCTRL_PIN(56, "GPIO_S0_SC56"), PINCTRL_PIN(57, "GPIO_S0_SC57"), PINCTRL_PIN(58, "GPIO_S0_SC58"), PINCTRL_PIN(59, "GPIO_S0_SC59"), PINCTRL_PIN(60, "GPIO_S0_SC60"), PINCTRL_PIN(61, "GPIO_S0_SC61"), but I don't really care that much ;-) My ack still applies to the whole series.
Powered by blists - more mailing lists