linux-kernel - Re: [PATCH 2/3 v2] ASoC: dwc: Add I2S HDMI audio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56FCEFD0.8090509@synopsys.com>
Date:	Thu, 31 Mar 2016 10:37:20 +0100
From:	Jose Abreu <Jose.Abreu@...opsys.com>
To:	Mark Brown <broonie@...nel.org>,
	Jose Abreu <Jose.Abreu@...opsys.com>
CC:	<tixy@...aro.org>, <mark.rutland@....com>,
	<alsa-devel@...a-project.org>, <Alexey.Brodkin@...opsys.com>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
	<yitian.bu@...gramtek.com>, <wsa+renesas@...g-engineering.com>,
	<laurent.pinchart+renesas@...asonboard.com>, <tiwai@...e.com>,
	<nariman@...nsource.wolfsonmicro.com>,
	<linux-snps-arc@...ts.infradead.org>, <devicetree@...r.kernel.org>,
	<Maruthi.Bayyavarapu@....com>, <pawel.moll@....com>,
	<ijc+devicetree@...lion.org.uk>, <Vineet.Gupta1@...opsys.com>,
	<buyitian@...il.com>, <robh+dt@...nel.org>, <perex@...ex.cz>,
	<lgirdwood@...il.com>, <CARLOS.PALMINHA@...opsys.com>,
	<galak@...eaurora.org>, <alexander.deucher@....com>
Subject: Re: [PATCH 2/3 v2] ASoC: dwc: Add I2S HDMI audio support

Hi Mark,

On 29-03-2016 19:22, Mark Brown wrote:
> On Tue, Mar 29, 2016 at 07:03:01PM +0100, Jose Abreu wrote:
>
>> The major part of this patch is the adding of an ALSA platform driver so that
>> audio comes out of the box in AXS boards but we also added functionalities to
>> the i2s driver and performed one bug fix related with the mask/unmask of
>> interrupts. I will split the patches but they will depend on each other.
> If you want to add a new platform driver you need to add a new platform
> driver, not shove the code into an existing driver for a seperate IP.
>

I can separate the platform driver into a new file but they will have to be
compiled into the same module as the new additions to the i2s driver depend on
functions of the platform driver (see i2s_irq_handler()). Or should I divide
this into two modules and add a Kconfig option to the platform driver? Besides
this I first wanted the driver to be compiled into the same module so that it is
compatible with kernel 3.18 where simple audio card requires that platform
driver == cpu driver.

Best regards,
Jose Miguel Abreu