linux-kernel - Re: [PATCH 2/3 v2] ASoC: dwc: Add I2S HDMI audio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160331165642.GG2350@sirena.org.uk>
Date:	Thu, 31 Mar 2016 09:56:42 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Jose Abreu <Jose.Abreu@...opsys.com>
Cc:	tixy@...aro.org, mark.rutland@....com, alsa-devel@...a-project.org,
	Alexey.Brodkin@...opsys.com, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org, yitian.bu@...gramtek.com,
	wsa+renesas@...g-engineering.com,
	laurent.pinchart+renesas@...asonboard.com, tiwai@...e.com,
	nariman@...nsource.wolfsonmicro.com,
	linux-snps-arc@...ts.infradead.org, devicetree@...r.kernel.org,
	Maruthi.Bayyavarapu@....com, pawel.moll@....com,
	ijc+devicetree@...lion.org.uk, Vineet.Gupta1@...opsys.com,
	buyitian@...il.com, robh+dt@...nel.org, perex@...ex.cz,
	lgirdwood@...il.com, CARLOS.PALMINHA@...opsys.com,
	galak@...eaurora.org, alexander.deucher@....com
Subject: Re: [PATCH 2/3 v2] ASoC: dwc: Add I2S HDMI audio support

On Thu, Mar 31, 2016 at 10:37:20AM +0100, Jose Abreu wrote:
> On 29-03-2016 19:22, Mark Brown wrote:

> > If you want to add a new platform driver you need to add a new platform
> > driver, not shove the code into an existing driver for a seperate IP.

> I can separate the platform driver into a new file but they will have to be
> compiled into the same module as the new additions to the i2s driver depend on
> functions of the platform driver (see i2s_irq_handler()). Or should I divide

No, that's not at all acceptable.  The Designware IP is not specific to
your system, you can't make it depend on your platform driver.  The
kernel needs to work on other people's systems too.  You need to work
through and/or extend the abstractions the framework provides to
separate the drivers for different IPs.

> this into two modules and add a Kconfig option to the platform driver? Besides
> this I first wanted the driver to be compiled into the same module so that it is
> compatible with kernel 3.18 where simple audio card requires that platform
> driver == cpu driver.

That's not OK upstream, we're working on the current kernel not on
random old kernels.  We don't carry compatibility code to enable current
kernel code to be run on years old kernels.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)