linux-kernel - RE: [PATCH 4/5] fsl/qe: Add QE TDM lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM3PR04MB11852B1F60CE58F0A877969291990@AM3PR04MB1185.eurprd04.prod.outlook.com>
Date:	Thu, 31 Mar 2016 01:25:11 +0000
From:	Qiang Zhao <qiang.zhao@....com>
To:	Joakim Tjernlund <Joakim.Tjernlund@...inera.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Xiaobo Xie <xiaobo.xie@....com>,
	"oss@...error.net" <oss@...error.net>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH 4/5] fsl/qe: Add QE TDM lib

On Wed, 2016-03-30 at 07:50PM, Joakim Tjernlund wrote:
> -----Original Message-----
> From: Joakim Tjernlund [mailto:Joakim.Tjernlund@...inera.com]
> Sent: Wednesday, March 30, 2016 7:50 PM
> To: davem@...emloft.net; Qiang Zhao <qiang.zhao@....com>
> Cc: linuxppc-dev@...ts.ozlabs.org; linux-kernel@...r.kernel.org; Xiaobo Xie
> <xiaobo.xie@....com>; oss@...error.net; gregkh@...uxfoundation.org;
> akpm@...ux-foundation.org; netdev@...r.kernel.org
> Subject: Re: [PATCH 4/5] fsl/qe: Add QE TDM lib
> 
> On Wed, 2016-03-30 at 16:50 +0800, Zhao Qiang wrote:
> > QE has module to support TDM, some other protocols supported by QE are
> > based on TDM.
> > add a qe-tdm lib, this lib provides functions to the protocols using
> > TDM to configurate QE-TDM.
> >
> > Signed-off-by: Zhao Qiang <qiang.zhao@....com>
> > +	utdm->siram_entry_id = val;
> > +
> > +	set_si_param(utdm, ut_info);
> > +
> > +	np2 = of_find_compatible_node(NULL, NULL, "fsl,t1040-qe-si");
> 
> fsl,t1040-qe-si only? What about mpc83xx?
> I recall QE is a little bit different compared to T1040 or will this work(including
> the hdlc driver) on 83xx as well?

The " fsl,t1040-qe-si " is new added to dts and bindings, it is required to have SoC specific compatible strings.
mpc83xx will not use qe-si node. If there will be other soc useing qe-si, " fsl,t1040-qe-si " will follow the soc specific compatible,
like : 
                si1: si@700 {
                        compatible = "fsl,ls1043-qe-si", "fsl,t1040-qe-si";
                        reg = <0x700 0x80>;
                };

Best Regards
Zhao Qiang