lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 31 Mar 2016 21:28:32 +0900 From: Chanwoo Choi <cwchoi00@...il.com> To: Sylwester Nawrocki <s.nawrocki@...sung.com> Cc: "myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>, Kyungmin Park <kyungmin.park@...sung.com>, Krzysztof Kozłowski <k.kozlowski@...sung.com>, Kukjin Kim <kgene@...nel.org>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Russell King - ARM Linux <linux@....linux.org.uk>, Anand Moon <linux.amoon@...il.com>, Markus Reichl <m.reichl@...etechno.de>, Tobias Jakobi <tjakobi@...h.uni-bielefeld.de>, "inki.dae@...sung.com" <inki.dae@...sung.com>, linux-kernel <linux-kernel@...r.kernel.org>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>, linux-samsung-soc <linux-samsung-soc@...r.kernel.org>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, devicetree <devicetree@...r.kernel.org> Subject: Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver On Thu, Mar 31, 2016 at 9:10 PM, Sylwester Nawrocki <s.nawrocki@...sung.com> wrote: > On 03/31/2016 11:05 AM, Chanwoo Choi wrote: > >> +static int exynos_bus_target(struct device *dev, unsigned long *freq, u32 flags) >> +{ > >> + new_opp = devfreq_recommended_opp(dev, freq, flags); >> + if (IS_ERR_OR_NULL(new_opp)) { >> + dev_err(dev, "failed to get recommed opp instance\n"); > > s/recommed/recommended/ OK. I'll fix it. > >> + rcu_read_unlock(); >> + return PTR_ERR(new_opp); >> + } > >> +} > >> +static int exynos_bus_probe(struct platform_device *pdev) >> +{ > >> + bus->devfreq = devm_devfreq_add_device(dev, profile, "simple_ondemand", >> + ondemand_data); >> + if (IS_ERR_OR_NULL(bus->devfreq)) { >> + dev_err(dev, "failed to add devfreq device\n"); >> + return PTR_ERR(bus->devfreq); >> + } > >> +} > > You should use IS_ERR() instead of IS_ERR_OR_NULL(), since functions > of which the return value is being tested return only ERR_PTR() values. > IS_ERR_OR_NULL() suggest NULL values are possible and then constructs > like > if (IS_ERR_OR_NULL(result)) > return PTR_ERR(result); > > are not correct anyway. OK. I'll use IS_ERR() instead of IS_ERR_OR_NULL() Thanks, Chanwoo Choi
Powered by blists - more mailing lists