linux-kernel - Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <56FD1E04.8050808@samsung.com>
Date:	Thu, 31 Mar 2016 14:54:28 +0200
From:	Sylwester Nawrocki <s.nawrocki@...sung.com>
To:	cw00.choi@...sung.com
Cc:	"myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Krzysztof Kozłowski <k.kozlowski@...sung.com>,
	Kukjin Kim <kgene@...nel.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Anand Moon <linux.amoon@...il.com>,
	Markus Reichl <m.reichl@...etechno.de>,
	Tobias Jakobi <tjakobi@...h.uni-bielefeld.de>,
	"inki.dae@...sung.com" <inki.dae@...sung.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	devicetree <devicetree@...r.kernel.org>
Subject: Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus
 frequency driver

On 03/31/2016 02:28 PM, Chanwoo Choi wrote:
>> > You should use IS_ERR() instead of IS_ERR_OR_NULL(), since functions
>> > of which the return value is being tested return only ERR_PTR() values.
>> > IS_ERR_OR_NULL() suggest NULL values are possible and then constructs
>> > like
>> >         if (IS_ERR_OR_NULL(result))
>> >                 return PTR_ERR(result);
>> >
>> > are not correct anyway.
>
> OK. I'll use IS_ERR() instead of IS_ERR_OR_NULL()

Thanks, I forgot to mention there is similar issue in patches
5/20 and 6/20.

--
Regards
Sylwester