linux-kernel - Re: [PATCH] hid: thingm: change driver to use RGB LED core extension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1604011139170.16158@cbobk.fhfr.pm>
Date:	Fri, 1 Apr 2016 11:40:04 +0200 (CEST)
From:	Jiri Kosina <jikos@...nel.org>
To:	Heiner Kallweit <hkallweit1@...il.com>
cc:	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Jacek Anaszewski <j.anaszewski@...sung.com>,
	linux-leds@...r.kernel.org, linux-input@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid: thingm: change driver to use RGB LED core
 extension

On Wed, 2 Mar 2016, Heiner Kallweit wrote:

> Based on the proposed RGB LED core extension the thingm driver was
> changed to make use of this extension. It allows to simplify
> the code a lot. For now primary purpose of this patch is to facilitate
> testing of the RGB LED core extension.
> 
> I didn't find a way to split the patch into smaller parts as either
> you use the RGB LED extension or not. However this shouldn't be really
> an issue as the resulting code is relatively short and simple.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

This patch clearly depends on some LED subsystem API that's not currently 
merged. Please let me know once this changes so that we could proceed with 
this patch.

I'm putting it on hold for now.

-- 
Jiri Kosina
SUSE Labs